From 4e09b23c4214eaf39a6efe8fb7a7656aee59b1e6 Mon Sep 17 00:00:00 2001 From: Oskar Lang Date: Wed, 14 Jan 2026 07:36:05 +0100 Subject: [PATCH 1/2] chore: avoid warning about passthrough --- .../minnced/discord/jdave/manager/DaveSessionManager.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java b/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java index f0df2ea..df76579 100644 --- a/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java +++ b/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java @@ -237,7 +237,13 @@ private void prepareProtocolTransition(int transitionId, int protocolVersion) { private void executeProtocolTransition(int transitionId) { Integer protocolVersion = preparedTransitions.remove(transitionId); + if (protocolVersion == null) { + if (transitionId == DaveConstants.INIT_TRANSITION_ID) { + log.debug("Passing through transition with ID 0"); + return; + } + log.warn("Unexpected Transition ID {}", transitionId); return; } From 685f92ada21caeccc7c04cd0da3c1322229a0e79 Mon Sep 17 00:00:00 2001 From: Oskar Lang Date: Wed, 14 Jan 2026 07:36:16 +0100 Subject: [PATCH 2/2] chore: avoid duplicated addUser call --- .../minnced/discord/jdave/manager/DaveSessionManager.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java b/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java index df76579..924ba97 100644 --- a/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java +++ b/api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java @@ -112,6 +112,10 @@ public DaveDecryptResultType decrypt( @SuppressWarnings("resource") public void addUser(long userId) { + if (decryptors.containsKey(userId)) { + return; + } + log.debug("Adding user {}", userId); DaveDecryptor decryptor = decryptors.computeIfAbsent(userId, id -> DaveDecryptor.create(id, session)); decryptor.prepareTransition(currentProtocolVersion);