Add minimal pre-commit config#406
Conversation
|
@phlexbot yaml-fix |
1 similar comment
|
@phlexbot yaml-fix |
|
Automatic YAML formatter fixes pushed (commit 6ac2d04). |
|
@olantwin, apologies about the YAML format problems. The changes in |
|
Note: we use |
Thanks for the pointer! Added. |
|
Rebased and removed the spurious changes in the .github CI workflows introduced by the yaml bot. |
|
@olantwin, thank you for this PR! It will simplify our development workflow in the way we had hoped. I've been testing it locally and encountered a few oddities. I'm not sure they have anything to do with the PR itself or something else...so I'll get back to you on that. Thank you for patience. |
The files in that directory import files that are generated during the build stage. They cannot be meaningfully linted during a pre-commit step.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 83.71% 84.25% +0.54%
==========================================
Files 126 128 +2
Lines 3291 3322 +31
Branches 583 564 -19
==========================================
+ Hits 2755 2799 +44
+ Misses 325 324 -1
+ Partials 211 199 -12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@olantwin, I pushed some changes to the configuration which, I believe, now brings the PR in line with GitHub actions. After this PR is merged, I will create another PR that applies the changes from |
|
No problem, hope it's going to be useful! |
greenc-FNAL
left a comment
There was a problem hiding this comment.
Any chance of an addition to DEVELOPING.md describing how to actually activate these hooks locally?
|
@greenc-FNAL Thanks for the feedback! I've added a few lines explaining the basic usage to |
|
@phlexbot markdown-fix |
Changes made by @olantwin in most recent commit
knoepfel
left a comment
There was a problem hiding this comment.
We'll deal with the markdown error in a separate PR. Right now, @phlexbot responds only to specific individuals (or individuals on a dedicated team...I can't remember which).
|
Thanks for this @olantwin! |
Implement #390 .
For now, only local hooks (no CI config).
For now ruff, clang-format and some of the hooks included with pre-commit.
I'll add cmake-format and jsonnet-fmt next.