Fix map-specific options in lobby not appearing#6562
Merged
Garanas merged 8 commits intoFAForever:developfrom Nov 29, 2024
Merged
Fix map-specific options in lobby not appearing#6562Garanas merged 8 commits intoFAForever:developfrom
Garanas merged 8 commits intoFAForever:developfrom
Conversation
If it ends with slash it doesn't work with the (currently unused) `GetPathToXMask` functions that append strings starting with a slash such as `/lobby/preview-buildable.dds`.
Garanas
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
pcallnot getting the return value from scenario loading files.maputils.lua#6495 bfe9c0dTesting done on the proposed changes
In the lobby, select a map with options such as a survival map; I used
/maps/dddx_rpg_survival.v0172/. The map's options should appear at the very bottom of the options list under the "Advanced" section.The scenario files are cached so a game reload or lobby reload is necessary to reload them and see the changes happen.
Checklist