Skip to content

Commit 47a606e

Browse files
authored
Simplify CI linting: use mise for shellcheck (#2)
1 parent fe68843 commit 47a606e

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,9 @@ jobs:
3434

3535
- uses: jdx/mise-action@v3
3636

37-
- name: Lint Go
37+
- name: Lint
3838
run: mise run lint
3939

40-
- name: Lint Shell
41-
uses: ludeeus/action-shellcheck@master
42-
with:
43-
scandir: ./bin
44-
severity: warning
45-
4640
test:
4741
runs-on: ubuntu-latest
4842
steps:

.mise.toml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,17 @@ description = "Run Go integration tests"
1313
depends = ["build"]
1414
run = "go test ./cmd/jjtask/cmd/..."
1515

16+
[tasks."lint:shell"]
17+
description = "Run shellcheck on shell scripts"
18+
run = "shellcheck bin/jj claude-plugin/bin/jj-guard"
19+
20+
[tasks."lint:go"]
21+
description = "Run golangci-lint"
22+
run = "golangci-lint run"
23+
1624
[tasks.lint]
1725
description = "Run all linters"
18-
run = """
19-
golangci-lint run
20-
shellcheck bin/jj claude-plugin/bin/jj-guard
21-
"""
26+
depends = ["lint:shell", "lint:go"]
2227

2328
[tasks.fmt]
2429
description = "Format Go code"
@@ -48,6 +53,7 @@ run = "./dev.sh"
4853

4954
[tasks.release]
5055
description = "Create and push a release tag (patch/minor/major or vX.Y.Z)"
56+
depends = ["ci"]
5157
run = """
5258
#!/usr/bin/env bash
5359
set -euo pipefail

0 commit comments

Comments
 (0)