Skip to content

Change return value of "detect_ramp_bounds" #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joeyshuttleworth wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Change return value of "detect_ramp_bounds" #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d75a1
Change returned values in detect_ramp_bounds
Feb 4, 2026
90919cd
Add clarification to docstring
Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pcpostprocess/detect_ramp_bounds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def detect_ramp_bounds(times, voltage_sections, ramp_index=0):
@param voltage_sections 2d np.array where each row describes a segment of the protocol: (tstart, tend, vstart, end)
@param ramp_index: the index of the ramp to select. Defaults to 0 - the first ramp

@returns istart, iend: the start and end timepoint indices for the specified ramp
@returns istart, iend: the first timepoint of the ramp segment, and the first time point of the following ramp segment
"""

ramps = [(tstart, tend, vstart, vend) for tstart, tend, vstart, vend
Expand All @@ -22,6 +22,6 @@ def detect_ramp_bounds(times, voltage_sections, ramp_index=0):

tstart, tend = ramp[:2]

ramp_bounds = [np.argmax(times > tstart), np.argmax(times > tend)]
ramp_bounds = [np.argmax(times >= tstart), np.argmax(times >= tend)]
return ramp_bounds