Add comprehensive test suite for rewards, detection, and utilities#344
Open
amussara wants to merge 1 commit intoBitMind-AI:mainfrom
Open
Add comprehensive test suite for rewards, detection, and utilities#344amussara wants to merge 1 commit intoBitMind-AI:mainfrom
amussara wants to merge 1 commit intoBitMind-AI:mainfrom
Conversation
…and duplicate detection - tests/test_rewards.py: 25+ tests covering discriminator rewards, generator base rewards, generator reward multipliers, liveness filtering, edge cases (empty/None inputs, invalid types, negative MCC clamping, custom weights) - tests/test_duplicate_detection.py: Tests for hash extraction, hamming distance, duplicate detection logic, crop-resistant matching, find_duplicates - tests/test_types.py: Tests for Modality, MediaType, SourceType enums, DatasetConfig validation, ModelConfig construction, DiscriminatorModelId serialization roundtrip - tests/test_cache_types.py: Tests for PromptEntry, MediaEntry, Media, VerificationResult dataclasses and their serialization - tests/test_utils.py: Tests for get_file_modality, get_metadata, ExitContext, fail_with_none decorator, run_in_thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 new test files covering rewards, duplicate detection, types, cache, and utils. 1,098 lines.