-
Notifications
You must be signed in to change notification settings - Fork 593
Description
What are you trying to do?
Our CI checks which run a clean install of aztec-up started failing yesterday. Upon further review, we noticed that this command:
aztec-up -v 3.0.0-devnet.6-patch.1succeeded immediately but did not pull nor install the specified aztec docker image. Subsequent commands (e.g. aztec compile) then fail because the latest image tag was implicitly used instead, which looks like a 2.1.x release which did not have this command.
Upon further review, we identified the root cause to be in the aztec-up install script, at this specific block:
if curl --head --silent --fail "$install_url" > /dev/null; then
bash <(curl -s "$install_url")
else
echo "Error: Install script not found at $install_url"
echo "Please check the version specified."
exit 1
fi
$install_url now redirects via https://install.aztec.network. I have confirmed the URL works via browser, and curl does not follow redirects unless specified. As a result, the script is not actually downloaded nor executed. Despite this, the script exits successfully, and causes issues further down when we run commands that assume the specified aztec version is installed, when in reality the version is not present.
Code Reference
To repro, from a fresh install, including images uninstalled and docker images pruned:
bash -i <(curl -sL https://install.aztec.network)
aztec-up -v 3.0.0-devnet.6-patch.1
echo $? # will respond with 0/success but exit immediately
docker images | grep aztec # target image version will not be foundAztec Version
3.0.0-devnet.6-patch.1
OS
Mac/Linux
Browser (if relevant)
No response
Node Version
No response
Additional Context
Our current (hacky) workaround is to just run a sed command to add the -L to ensure that curl follows the redirects.
- name: Install Aztec
run: |
curl -sL https://install.aztec.network | SKIP_PULL=1 bash
echo "$HOME/.aztec/bin" >> $GITHUB_PATH
sed -i 's|curl -s |curl -sL |g' $HOME/.aztec/bin/aztec-up
- name: Install Aztec (cont'd)
run: aztec-up -v 3.0.0-devnet.6-patch.1