From 43e25534655f0659bf41b3e9b9284b961e4c2692 Mon Sep 17 00:00:00 2001
From: Philippe Matray <phmatray@gmail.com>
Date: Mon, 9 Mar 2026 10:03:15 +0100
Subject: [PATCH] fix(ci): resolve Biome lint errors breaking CI pipeline

- Update biome.json schema to 2.4.6 and enable Tailwind CSS directives
- Configure VCS-aware linting and downgrade pre-existing lint warnings
- Fix forEach callback return values (useIterableCallbackReturn)
- Add type="button" to button elements (useButtonType)
- Fix useRecentRepos hook declaration order (noInvalidUseBeforeDeclaration)
- Prefix unused destructured variables with underscore
- Auto-format renovate.json and index.css per Biome rules
---
 .planning/debug/viewer3d-standalone.html      | 14 ++++----
 biome.json                                    | 36 +++++++++++++++++--
 renovate.json                                 |  9 ++---
 .../blades/_shared/WorkflowNavigation.tsx     |  1 +
 src/core/hooks/useRecentRepos.ts              | 14 ++++----
 .../branches/components/BranchItem.tsx        |  5 ++-
 .../branches/components/BranchList.tsx        |  4 +--
 src/framework/stores/registry.ts              |  4 ++-
 src/index.css                                 | 18 +++++-----
 9 files changed, 68 insertions(+), 37 deletions(-)

diff --git a/.planning/debug/viewer3d-standalone.html b/.planning/debug/viewer3d-standalone.html
index f45d4ca..57ec03a 100644
--- a/.planning/debug/viewer3d-standalone.html
+++ b/.planning/debug/viewer3d-standalone.html
@@ -177,8 +177,8 @@
     <h1>FlowForge 3D Viewer Debug</h1>
     <span id="overall-status" class="status pending">Pending</span>
     <span style="flex:1"></span>
-    <button class="secondary" onclick="clearLog()">Clear Log</button>
-    <button class="secondary" onclick="runAllTests()">Run All Tests</button>
+    <button type="button" class="secondary" onclick="clearLog()">Clear Log</button>
+    <button type="button" class="secondary" onclick="runAllTests()">Run All Tests</button>
   </div>
 
   <div class="main">
@@ -227,7 +227,7 @@ <h2>Environment Checks</h2>
         <h2>Load GLB/GLTF File</h2>
         <div class="controls">
           <input type="file" id="file-input" accept=".glb,.gltf" />
-          <button id="btn-load-file" onclick="loadFromFile()" disabled>
+          <button type="button" id="btn-load-file" onclick="loadFromFile()" disabled>
             Test: Direct File Load
           </button>
         </div>
@@ -238,10 +238,10 @@ <h2>Load GLB/GLTF File</h2>
         <h2>Test Base64 Pipeline (simulates Tauri)</h2>
         <div class="controls">
           <textarea id="base64-input" placeholder="Paste base64-encoded GLB data here, or use 'Load File as Base64' button below..."></textarea>
-          <button id="btn-load-base64" onclick="loadFromBase64()" disabled>
+          <button type="button" id="btn-load-base64" onclick="loadFromBase64()" disabled>
             Test: Base64 Decode + Parse
           </button>
-          <button id="btn-file-to-base64" onclick="fileToBase64()" disabled>
+          <button type="button" id="btn-file-to-base64" onclick="fileToBase64()" disabled>
             Load File as Base64 (round-trip test)
           </button>
         </div>
@@ -251,10 +251,10 @@ <h2>Test Base64 Pipeline (simulates Tauri)</h2>
       <div class="section">
         <h2>Quick Test</h2>
         <div class="controls">
-          <button onclick="loadSampleCube()">
+          <button type="button" onclick="loadSampleCube()">
             Test: Procedural Cube (no file needed)
           </button>
-          <button onclick="fetchSampleModel()">
+          <button type="button" onclick="fetchSampleModel()">
             Test: Fetch BoxAnimated.glb from GitHub
           </button>
         </div>
diff --git a/biome.json b/biome.json
index b33c2a8..63aa00a 100644
--- a/biome.json
+++ b/biome.json
@@ -1,6 +1,36 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.4.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.4.6/schema.json",
   "assist": { "actions": { "source": { "organizeImports": "on" } } },
-  "linter": { "enabled": true, "rules": { "recommended": true } },
-  "formatter": { "enabled": true, "indentStyle": "space", "indentWidth": 2 }
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "suspicious": {
+        "noExplicitAny": "warn",
+        "noArrayIndexKey": "warn"
+      },
+      "style": {
+        "noNonNullAssertion": "warn"
+      },
+      "a11y": {
+        "recommended": true,
+        "useButtonType": "warn",
+        "noLabelWithoutControl": "warn",
+        "noStaticElementInteractions": "warn",
+        "useSemanticElements": "warn",
+        "useKeyWithClickEvents": "warn",
+        "useAriaPropsSupportedByRole": "warn",
+        "noSvgWithoutTitle": "warn",
+        "useFocusableInteractive": "warn",
+        "useAriaPropsForRole": "warn"
+      }
+    }
+  },
+  "formatter": { "enabled": true, "indentStyle": "space", "indentWidth": 2 },
+  "css": { "parser": { "tailwindDirectives": true } },
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  }
 }
diff --git a/renovate.json b/renovate.json
index e48fa99..ed38296 100644
--- a/renovate.json
+++ b/renovate.json
@@ -1,14 +1,9 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
-  "extends": [
-    "config:recommended"
-  ],
+  "extends": ["config:recommended"],
   "packageRules": [
     {
-      "matchUpdateTypes": [
-        "minor",
-        "patch"
-      ],
+      "matchUpdateTypes": ["minor", "patch"],
       "automerge": true
     }
   ],
diff --git a/src/core/blades/_shared/WorkflowNavigation.tsx b/src/core/blades/_shared/WorkflowNavigation.tsx
index 1944936..3494a89 100644
--- a/src/core/blades/_shared/WorkflowNavigation.tsx
+++ b/src/core/blades/_shared/WorkflowNavigation.tsx
@@ -58,6 +58,7 @@ export function WorkflowNavigation({ className }: WorkflowNavigationProps) {
         const Icon = WORKFLOW_ICONS[id] ?? Files;
         return (
           <button
+            type="button"
             key={id}
             onClick={() =>
               actorRef.send({ type: "SWITCH_WORKFLOW", workflow: id })
diff --git a/src/core/hooks/useRecentRepos.ts b/src/core/hooks/useRecentRepos.ts
index 3137772..583e935 100644
--- a/src/core/hooks/useRecentRepos.ts
+++ b/src/core/hooks/useRecentRepos.ts
@@ -15,12 +15,7 @@ export function useRecentRepos() {
   const [recentRepos, setRecentRepos] = useState<RecentRepo[]>([]);
   const [isLoading, setIsLoading] = useState(true);
 
-  // Load recent repos on mount
-  useEffect(() => {
-    loadRecentRepos();
-  }, [loadRecentRepos]);
-
-  const loadRecentRepos = async () => {
+  const loadRecentRepos = useCallback(async () => {
     try {
       const store = await getStore();
       const repos = await store.get<RecentRepo[]>(RECENT_REPOS_KEY);
@@ -31,7 +26,12 @@ export function useRecentRepos() {
     } finally {
       setIsLoading(false);
     }
-  };
+  }, []);
+
+  // Load recent repos on mount
+  useEffect(() => {
+    loadRecentRepos();
+  }, [loadRecentRepos]);
 
   const addRecentRepo = useCallback(async (path: string, name?: string) => {
     try {
diff --git a/src/extensions/branches/components/BranchItem.tsx b/src/extensions/branches/components/BranchItem.tsx
index c49e0fc..311f536 100644
--- a/src/extensions/branches/components/BranchItem.tsx
+++ b/src/extensions/branches/components/BranchItem.tsx
@@ -40,7 +40,10 @@ function AheadBehindBadge({
       gitHookBus.onDid("fetch", bump, "ahead-behind-badge"),
       gitHookBus.onDid("pull", bump, "ahead-behind-badge"),
     ];
-    return () => unsubs.forEach((u) => u());
+    return () =>
+      unsubs.forEach((u) => {
+        u();
+      });
   }, [isRemote]);
 
   if (!counts || (counts.ahead === 0 && counts.behind === 0)) return null;
diff --git a/src/extensions/branches/components/BranchList.tsx b/src/extensions/branches/components/BranchList.tsx
index ff7521f..7b70576 100644
--- a/src/extensions/branches/components/BranchList.tsx
+++ b/src/extensions/branches/components/BranchList.tsx
@@ -52,8 +52,8 @@ export function BranchList({
   const {
     mergeResult: lastMergeResult,
     startMerge,
-    abort: abortMerge,
-    isMerging: mergeIsLoading,
+    abort: _abortMerge,
+    isMerging: _mergeIsLoading,
   } = useMergeWorkflow();
   const [mergingBranch, setMergingBranch] = useState<string | null>(null);
 
diff --git a/src/framework/stores/registry.ts b/src/framework/stores/registry.ts
index 401b326..6a3ee62 100644
--- a/src/framework/stores/registry.ts
+++ b/src/framework/stores/registry.ts
@@ -3,7 +3,9 @@ import type { StoreApi } from "zustand";
 const storeResetFns = new Set<() => void>();
 
 export function resetAllStores(): void {
-  storeResetFns.forEach((resetFn) => resetFn());
+  storeResetFns.forEach((resetFn) => {
+    resetFn();
+  });
 }
 
 export function registerStoreForReset<T>(store: StoreApi<T>): void {
diff --git a/src/index.css b/src/index.css
index d660bec..e17c8c2 100644
--- a/src/index.css
+++ b/src/index.css
@@ -4,15 +4,15 @@
 @import "@fontsource-variable/geist";
 
 @theme {
-    --font-sans:
-        "Geist Variable", system-ui, -apple-system, BlinkMacSystemFont,
-        "Segoe UI", Roboto, sans-serif;
-    --font-mono:
-        "JetBrains Mono Variable", ui-monospace, "SF Mono", "Monaco",
-        "Cascadia Code", "Consolas", monospace;
-    --animate-dirty-pulse: dirty-pulse 2s ease-in-out infinite;
-    --animate-gentle-pulse: gentle-pulse 3s ease-in-out infinite;
-    --animate-stage-flash: stage-flash 0.3s ease-out;
+  --font-sans:
+    "Geist Variable", system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI",
+    Roboto, sans-serif;
+  --font-mono:
+    "JetBrains Mono Variable", ui-monospace, "SF Mono", "Monaco",
+    "Cascadia Code", "Consolas", monospace;
+  --animate-dirty-pulse: dirty-pulse 2s ease-in-out infinite;
+  --animate-gentle-pulse: gentle-pulse 3s ease-in-out infinite;
+  --animate-stage-flash: stage-flash 0.3s ease-out;
 }
 
 /*