-
Notifications
You must be signed in to change notification settings - Fork 182
Add Non-HFE–enhanced dataset #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We will produce a Non-HFE–enhanced dataset by generating Monte Carlo samples with increased π⁰ and η production, to improve the statistical precision of the non-HFE efficiency measurement.
We will produce a Non-HFE–enhanced dataset by generating Monte Carlo samples with increased π⁰ and η production, to improve the statistical precision of the non-HFE efficiency measurement.
We will produce a Non-HFE–enhanced dataset by generating Monte Carlo samples with increased π⁰ and η production, to improve the statistical precision of the non-HFE efficiency measurement.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Hi @rashigupt ! Thanks for the development. I just have a doubt from my side: why using a gap-triggered configuration if you disable all HF decays? Why can't you use a standard generator? |
|
hi @stefanopolitano, Yes, I disabled all HF decays while producing the enhanced sample because I want to generate enhanced pion and eta statistics in order to obtain a sufficient number of non-heavy-flavour (background) electrons. When I used the general-purpose dataset, the statistics for Non-HFE were too low. |
|
Hello @rashigupt , I see from your PR that you have GeneratorHF_Non_Hfe_enhance.ini, but GeneratorHF_Non_Hfe.C as test. This will not work because the CI will check a .C macro named in the same way as your ini file. Could you please rename the test? |
|
Hi @rashigupt ! Sorry for the late response, but I think I am not getting your point. For my understanding, if you want pions and eta not coming from HF, what is the point of using gap trigger to include ccbar/bbbar events? |
ok |
…Hfe.ini Rename File and add nonHfe.c file
Add generator_pythia8_gaptriggered_nonhfe.C file for enance pion and eta
Hi, sorry for the late reply. You're right — using a gap trigger doesn't make sense for non-HFE pions and η. I've updated the code and created a separate file without the gap trigger for the non-HFE case. |
|
Dear all, please apprvoe and merge this code. |
|
Hi @rashigupt could you please fix the test? This is the current error making the CI fail |
|
Hi, @jackal1-66 ,I’m still not sure how to fix this. Could you please guide me? |
Ciao @rashigupt I had a look at your test. I think the problem is that you're assuming nEventsInjOne, and other counters should be half of the total injected events, while in reality the factor is 1/3 (considering 3 quarks species by default). This should fix the problem you're experiencing in the CI |
|
hi @jackal1-66 , Thank you for the suggestion. |
|
hi @jackal1-66 , I updated the text file as suggested, using the 1/3 factor instead of 1/2 for the event counters. However, the CI is still failing with the same error. |
|
Ciao @rashigupt,
|
|
Thank you @jackal1-66 for your comments. |
|
@stefanopolitano can you check this out? Missing HF approval for merging |
|
Hi @rashigupt and @jackal1-66, thanks for the huge work and sorry for the delay! I still have some comments on this PR that I list here below.
|
|
hi @stefanopolitano , Thank you for your comments.
|
|
Hi @rashigupt, I think what you are describing in your point 1. is exactly what is done in the case of an external trigger. Personally, I would suggest to go in that direction instead of having a dedicated generator, which at this point won't be used as generator but as a trigger. Regarding your second point, to me is quite strange to suppress HF decays. My naive expectation would be that if you turn them off you are biasing the topology of your events with respect to a realistic data taking. For instance, I would expect the multiplicity of your events to be smaller than the one obtained in a MC in which the HF hadrons are allowed to decay. Similarly, also the occupancy will be different, the resolution on the primary vertex, etc. Have you checked the impact of this choice on the reconstruction efficiency of pion and eta? In addition, by looking at previous analyses (https://alice-notes.web.cern.ch/system/files/notes/analysis/1172/2023-03-23-EHCorrelation_AN_pp_pPb_2021-1.pdf), it seems to me that the HF decays were considered, even when enhancing the pi0 and eta contributions. |
We will produce a Non-HFE–enhanced dataset by generating Monte Carlo samples with increased π⁰ and η production, to improve the statistical precision of the non-HFE efficiency measurement.