From 79a1d392cce068f91593840ac44cf66764dd98ad Mon Sep 17 00:00:00 2001
From: Pedro Lima <pedro@twentythree.com>
Date: Fri, 28 Mar 2025 15:43:06 +0100
Subject: [PATCH] fix(player-accessibility): add missing labels that caused
 some issues

---
 src/playback-rate-button/playback-rate-button.liquid | 3 ++-
 src/quality-button/quality-button.liquid             | 5 +++--
 src/sharing/sharing.js                               | 4 ++++
 src/sharing/sharing.liquid                           | 5 ++++-
 4 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/playback-rate-button/playback-rate-button.liquid b/src/playback-rate-button/playback-rate-button.liquid
index 6cd45c2a..0692049d 100644
--- a/src/playback-rate-button/playback-rate-button.liquid
+++ b/src/playback-rate-button/playback-rate-button.liquid
@@ -18,7 +18,8 @@
     <ul
       id="playbackRateOptions"
       class="button-menu button-menu-selection"
-      role="menu">
+      role="menu"
+      aria-labelledby="playback-rate-button">
       {% for pr in playbackRatesArray %}
         <li {% if pr.rate == playbackRate %}class="selected"{% endif %}>
           <button
diff --git a/src/quality-button/quality-button.liquid b/src/quality-button/quality-button.liquid
index d6db5cb2..d3b5976c 100644
--- a/src/quality-button/quality-button.liquid
+++ b/src/quality-button/quality-button.liquid
@@ -19,6 +19,7 @@
       id="qualityOptions"
       class="button-menu button-menu-selection"
       role="menu"
+      aria-labelledby="quality-button"
       >
       {% for q in qualitiesArray %}
         <li {% if q.quality == quality %}class="selected"{% endif %}>
@@ -26,8 +27,8 @@
             class="button-menu-item"
             click="$set:quality:{{q.quality}}; $set:playing:true"
             {% if q.quality == quality %}aria-checked="true"{% else %}aria-checked="false"{% endif %}
-            aria-label="{{q.quality}} {{"quality_2"|translate}}"
-            label="{{q.quality}} {{"quality_2"|translate}}"
+            aria-label="{{q.displayQuality}} {{"quality_2"|translate}}"
+            label="{{q.displayQuality}} {{"quality_2"|translate}}"
             role="menuitemradio"
             tabindex="0">{{ q.displayQuality }}</button>
         </li>
diff --git a/src/sharing/sharing.js b/src/sharing/sharing.js
index 3f752b82..7a16d0ee 100644
--- a/src/sharing/sharing.js
+++ b/src/sharing/sharing.js
@@ -235,3 +235,7 @@ Player.translate("more_sharing_options",{
 Player.translate("download_video",{
     en: "Download video"
 });
+Player.translate("close_share_menu", {
+    en: "Close share menu"
+} )
+
diff --git a/src/sharing/sharing.liquid b/src/sharing/sharing.liquid
index 51e597b2..cc385835 100644
--- a/src/sharing/sharing.liquid
+++ b/src/sharing/sharing.liquid
@@ -13,7 +13,10 @@
   </div>
 
   <div class="button-container button-container-close">
-    <button class="close-button" click="$set:showSharing:false"></button>
+    <button class="close-button"
+            aria-label="{{"close_share_menu"|translate}}"
+            click="$set:showSharing:false"></button>
+
   </div>
 
   <table class="share-buttons-container">